Icycoide/RSCC-Forge
1
0
Fork 0
forked from kevadesu/forgejo
Code Pull requests Activity

Improve issue list filter (#24425)

Browse source 
Partial regression of #24393, not only regression, but broken for long
time, 24393 didn't really improve it but used wrong `overflow: scroll`.

Actually, that "ui secondary filter menu labels" shouldn't be set as
scrollable (I missed that at that time), the problem is: if a "ui menu"
has "dropdown" items, then it should not be scrollable. Otherwise the
dropdown menu can't be shown correctly.

And there are more problems:

* The "issue-filters" shouldn't be used anywhere else (copying&pasting
problem again ....)
* There is also an "issue-actions" container, it should also be fixed.
* There are similar problems on the milestone page.
* The old comment in code: "grid column" doesn't work well.

The major changes of this PR are: use "flex: 1" instead of "ui grid
column".

After this PR, not 100% perfect but much better than before.
This commit is contained in:
wxiaoguang 2023-04-30 23:51:20 +08:00 • committed by GitHub
parent e8173c2c33
commit 14c142b0bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 51 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

17
web_src/css/repository.css
View file

@ -141,12 +141,19 @@
font-size: 11px;
}
.repository .filter.menu .menu {
/* make all issue filter dropdown menus popup leftward, to avoid go out the viewport (right side) */
.repository .filter.menu .ui.dropdown .menu {
max-height: 500px;
max-width: 300px;
overflow-x: hidden;
right: 0 !important;
left: auto !important;
right: 0;
left: auto;
}
/* the label-filter is the first dropdown, it shouldn't be shown leftward, otherwise it may go out the viewport (left side) */
.repository .filter.menu .ui.dropdown.label-filter .menu {
right: unset;
left: 0;
}
.repository .select-label .desc {
@ -2394,10 +2401,6 @@
margin: 6px 0;
}
#issue-actions {
margin-top: -1rem !important; /* counteract padding from Semantic */
}
.ui.menu .item > img:not(.ui) {
width: auto;
}