From 49c5fc565c326a7b8be190e5109fffefc2cf5ec1 Mon Sep 17 00:00:00 2001
From: Gusted <williamzijl7@hotmail.com>
Date: Sun, 20 Mar 2022 21:04:51 +0000
Subject: [PATCH] Fix NPE `/repos/issues/search` when not signed in (#19154)
- Don't panic when on
`/repos/issues/search?{created,assigned,mentioned,review_requested}=true`
when client didn't pass any authentication.
- Resolves #19115
---
routers/api/v1/repo/issue.go | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/routers/api/v1/repo/issue.go b/routers/api/v1/repo/issue.go
index 9e550c4c47..c96eb34855 100644
--- a/routers/api/v1/repo/issue.go
+++ b/routers/api/v1/repo/issue.go
@@ -245,18 +245,23 @@ func SearchIssues(ctx *context.APIContext) {
UpdatedAfterUnix: since,
}
+ ctxUserID := int64(0)
+ if ctx.IsSigned {
+ ctxUserID = ctx.User.ID
+ }
+
// Filter for: Created by User, Assigned to User, Mentioning User, Review of User Requested
if ctx.FormBool("created") {
- issuesOpt.PosterID = ctx.User.ID
+ issuesOpt.PosterID = ctxUserID
}
if ctx.FormBool("assigned") {
- issuesOpt.AssigneeID = ctx.User.ID
+ issuesOpt.AssigneeID = ctxUserID
}
if ctx.FormBool("mentioned") {
- issuesOpt.MentionedID = ctx.User.ID
+ issuesOpt.MentionedID = ctxUserID
}
if ctx.FormBool("review_requested") {
- issuesOpt.ReviewRequestedID = ctx.User.ID
+ issuesOpt.ReviewRequestedID = ctxUserID
}
if issues, err = models.Issues(issuesOpt); err != nil {