Add testifylint to lint checks (#4535)

go-require lint is ignored for now

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4535
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>

modules/lfs/http_client_test.go

@@ -14,6 +14,7 @@ import (
 	"code.gitea.io/gitea/modules/json"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 type RoundTripFunc func(req *http.Request) *http.Response
@@ -170,7 +171,7 @@ func TestHTTPClientDownload(t *testing.T) {
 
 		var batchRequest BatchRequest
 		err := json.NewDecoder(req.Body).Decode(&batchRequest)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
 		assert.Equal(t, "download", batchRequest.Operation)
 		assert.Len(t, batchRequest.Objects, 1)
@@ -261,14 +262,14 @@ func TestHTTPClientDownload(t *testing.T) {
 				return objectError
 			}
 			b, err := io.ReadAll(content)
-			assert.NoError(t, err)
+			require.NoError(t, err)
 			assert.Equal(t, []byte("dummy"), b)
 			return nil
 		})
 		if len(c.expectederror) > 0 {
 			assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror)
 		} else {
-			assert.NoError(t, err, "case %d", n)
+			require.NoError(t, err, "case %d", n)
 		}
 	}
 }
@@ -283,7 +284,7 @@ func TestHTTPClientUpload(t *testing.T) {
 
 		var batchRequest BatchRequest
 		err := json.NewDecoder(req.Body).Decode(&batchRequest)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
 		assert.Equal(t, "upload", batchRequest.Operation)
 		assert.Len(t, batchRequest.Objects, 1)
@@ -370,7 +371,7 @@ func TestHTTPClientUpload(t *testing.T) {
 		if len(c.expectederror) > 0 {
 			assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror)
 		} else {
-			assert.NoError(t, err, "case %d", n)
+			require.NoError(t, err, "case %d", n)
 		}
 	}
 }

modules/lfs/pointer_test.go

@@ -9,6 +9,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestStringContent(t *testing.T) {
@@ -45,7 +46,7 @@ func TestIsValid(t *testing.T) {
 
 func TestGeneratePointer(t *testing.T) {
 	p, err := GeneratePointer(strings.NewReader("Gitea"))
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.True(t, p.IsValid())
 	assert.Equal(t, "94cb57646c54a297c9807697e80a30946f79a4b82cb079d2606847825b1812cc", p.Oid)
 	assert.Equal(t, int64(5), p.Size)
@@ -53,41 +54,41 @@ func TestGeneratePointer(t *testing.T) {
 
 func TestReadPointerFromBuffer(t *testing.T) {
 	p, err := ReadPointerFromBuffer([]byte{})
-	assert.ErrorIs(t, err, ErrMissingPrefix)
+	require.ErrorIs(t, err, ErrMissingPrefix)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("test"))
-	assert.ErrorIs(t, err, ErrMissingPrefix)
+	require.ErrorIs(t, err, ErrMissingPrefix)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\n"))
-	assert.ErrorIs(t, err, ErrInvalidStructure)
+	require.ErrorIs(t, err, ErrInvalidStructure)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a\nsize 1234\n"))
-	assert.ErrorIs(t, err, ErrInvalidOIDFormat)
+	require.ErrorIs(t, err, ErrInvalidOIDFormat)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a2146z4ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393\nsize 1234\n"))
-	assert.ErrorIs(t, err, ErrInvalidOIDFormat)
+	require.ErrorIs(t, err, ErrInvalidOIDFormat)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393\ntest 1234\n"))
-	assert.Error(t, err)
+	require.Error(t, err)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393\nsize test\n"))
-	assert.Error(t, err)
+	require.Error(t, err)
 	assert.False(t, p.IsValid())
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393\nsize 1234\n"))
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.True(t, p.IsValid())
 	assert.Equal(t, "4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393", p.Oid)
 	assert.Equal(t, int64(1234), p.Size)
 
 	p, err = ReadPointerFromBuffer([]byte("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393\nsize 1234\ntest"))
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.True(t, p.IsValid())
 	assert.Equal(t, "4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393", p.Oid)
 	assert.Equal(t, int64(1234), p.Size)
@@ -95,7 +96,7 @@ func TestReadPointerFromBuffer(t *testing.T) {
 
 func TestReadPointer(t *testing.T) {
 	p, err := ReadPointer(strings.NewReader("version https://git-lfs.github.com/spec/v1\noid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393\nsize 1234\n"))
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.True(t, p.IsValid())
 	assert.Equal(t, "4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393", p.Oid)
 	assert.Equal(t, int64(1234), p.Size)

modules/lfs/transferadapter_test.go

@@ -14,6 +14,7 @@ import (
 	"code.gitea.io/gitea/modules/json"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestBasicTransferAdapterName(t *testing.T) {
@@ -39,7 +40,7 @@ func TestBasicTransferAdapter(t *testing.T) {
 			assert.Equal(t, "application/octet-stream", req.Header.Get("Content-Type"))
 
 			b, err := io.ReadAll(req.Body)
-			assert.NoError(t, err)
+			require.NoError(t, err)
 			assert.Equal(t, "dummy", string(b))
 
 			return &http.Response{StatusCode: http.StatusOK}
@@ -49,7 +50,7 @@ func TestBasicTransferAdapter(t *testing.T) {
 
 			var vp Pointer
 			err := json.NewDecoder(req.Body).Decode(&vp)
-			assert.NoError(t, err)
+			require.NoError(t, err)
 			assert.Equal(t, p.Oid, vp.Oid)
 			assert.Equal(t, p.Size, vp.Size)
 
@@ -98,7 +99,7 @@ func TestBasicTransferAdapter(t *testing.T) {
 			if len(c.expectederror) > 0 {
 				assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror)
 			} else {
-				assert.NoError(t, err, "case %d", n)
+				require.NoError(t, err, "case %d", n)
 			}
 		}
 	})
@@ -131,7 +132,7 @@ func TestBasicTransferAdapter(t *testing.T) {
 			if len(c.expectederror) > 0 {
 				assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror)
 			} else {
-				assert.NoError(t, err, "case %d", n)
+				require.NoError(t, err, "case %d", n)
 			}
 		}
 	})
@@ -164,7 +165,7 @@ func TestBasicTransferAdapter(t *testing.T) {
 			if len(c.expectederror) > 0 {
 				assert.True(t, strings.Contains(err.Error(), c.expectederror), "case %d: '%s' should contain '%s'", n, err.Error(), c.expectederror)
 			} else {
-				assert.NoError(t, err, "case %d", n)
+				require.NoError(t, err, "case %d", n)
 			}
 		}
 	})