From 6427fa65b641a32ead53779e3e7bda97704567df Mon Sep 17 00:00:00 2001
From: Gusted <postmaster@gusted.xyz>
Date: Sun, 17 Sep 2023 20:25:30 +0200
Subject: [PATCH] [GITEA] Skip unsupported code comment
- If there's a code comment that's received during the migration that
contains no diffhunk, skip it. This either means it was commenting on
old diffhunk or it's just a general codecomment. Forgejo supports
neither of such type of code comment.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1407
(cherry picked from commit ae463c7c559e02975ce5e758d8780def978eebee)
(cherry picked from commit bf48f02a86d6a193417f13a77031b8207a173dca)
(cherry picked from commit 10c3f102fa9135de37e9f73137ae5a9cf7072635)
(cherry picked from commit 828b4cc10cd0fc7e2540fe75e88b6ebf978c5c84)
---
services/migrations/gitea_uploader.go | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/services/migrations/gitea_uploader.go b/services/migrations/gitea_uploader.go
index ebf22e0e40..de262d431c 100644
--- a/services/migrations/gitea_uploader.go
+++ b/services/migrations/gitea_uploader.go
@@ -859,6 +859,11 @@ func (g *GiteaLocalUploader) CreateReviews(reviews ...*base.Review) error {
}
for _, comment := range review.Comments {
+ // Skip code comment if it doesn't have a diff it is commeting on.
+ if comment.DiffHunk == "" {
+ continue
+ }
+
line := comment.Line
if line != 0 {
comment.Position = 1