From 7bde2bf80945ef5d0e973e8bb7e7899b020564d7 Mon Sep 17 00:00:00 2001
From: Earl Warren <109468362+earl-warren@users.noreply.github.com>
Date: Thu, 3 Aug 2023 03:38:51 +0200
Subject: [PATCH] add unit test for user renaming (#26261)
- The user renaming function has zero test coverage.
- This patch brings that up to speed to test for various scenarios and
ensure that in a normal workflow the correct things has changed to their
respective new value. Most scenarios are to ensure certain things DO NOT
happen.
(cherry picked from commit 5b9d34ed115c9ef24012b8027959ea0afdcb4e2d)
Refs: https://codeberg.org/forgejo/forgejo/pulls/1156
Co-authored-by: Gusted <postmaster@gusted.xyz>
---
services/user/user_test.go | 64 ++++++++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
diff --git a/services/user/user_test.go b/services/user/user_test.go
index a25804fceb..3f1bf9a0f8 100644
--- a/services/user/user_test.go
+++ b/services/user/user_test.go
@@ -4,10 +4,13 @@
package user
import (
+ "fmt"
"path/filepath"
+ "strings"
"testing"
"code.gitea.io/gitea/models"
+ "code.gitea.io/gitea/models/auth"
"code.gitea.io/gitea/models/db"
"code.gitea.io/gitea/models/organization"
repo_model "code.gitea.io/gitea/models/repo"
@@ -94,6 +97,67 @@ func TestCreateUser(t *testing.T) {
assert.NoError(t, DeleteUser(db.DefaultContext, user, false))
}
+func TestRenameUser(t *testing.T) {
+ assert.NoError(t, unittest.PrepareTestDatabase())
+ user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 21})
+
+ t.Run("Non-Local", func(t *testing.T) {
+ u := &user_model.User{
+ Type: user_model.UserTypeIndividual,
+ LoginType: auth.OAuth2,
+ }
+ assert.ErrorIs(t, RenameUser(db.DefaultContext, u, "user_rename"), user_model.ErrUserIsNotLocal{})
+ })
+
+ t.Run("Same username", func(t *testing.T) {
+ assert.ErrorIs(t, RenameUser(db.DefaultContext, user, user.Name), user_model.ErrUsernameNotChanged{UID: user.ID, Name: user.Name})
+ })
+
+ t.Run("Non usable username", func(t *testing.T) {
+ usernames := []string{"--diff", "aa.png", ".well-known", "search", "aaa.atom"}
+ for _, username := range usernames {
+ t.Run(username, func(t *testing.T) {
+ assert.Error(t, user_model.IsUsableUsername(username))
+ assert.Error(t, RenameUser(db.DefaultContext, user, username))
+ })
+ }
+ })
+
+ t.Run("Only capitalization", func(t *testing.T) {
+ caps := strings.ToUpper(user.Name)
+ unittest.AssertNotExistsBean(t, &user_model.User{ID: user.ID, Name: caps})
+ unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerID: user.ID, OwnerName: user.Name})
+
+ assert.NoError(t, RenameUser(db.DefaultContext, user, caps))
+
+ unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: user.ID, Name: caps})
+ unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerID: user.ID, OwnerName: caps})
+ })
+
+ t.Run("Already exists", func(t *testing.T) {
+ existUser := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
+
+ assert.ErrorIs(t, RenameUser(db.DefaultContext, user, existUser.Name), user_model.ErrUserAlreadyExist{Name: existUser.Name})
+ assert.ErrorIs(t, RenameUser(db.DefaultContext, user, existUser.LowerName), user_model.ErrUserAlreadyExist{Name: existUser.LowerName})
+ newUsername := fmt.Sprintf("uSEr%d", existUser.ID)
+ assert.ErrorIs(t, RenameUser(db.DefaultContext, user, newUsername), user_model.ErrUserAlreadyExist{Name: newUsername})
+ })
+
+ t.Run("Normal", func(t *testing.T) {
+ oldUsername := user.Name
+ newUsername := "User_Rename"
+
+ assert.NoError(t, RenameUser(db.DefaultContext, user, newUsername))
+ unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: user.ID, Name: newUsername, LowerName: strings.ToLower(newUsername)})
+
+ redirectUID, err := user_model.LookupUserRedirect(oldUsername)
+ assert.NoError(t, err)
+ assert.EqualValues(t, user.ID, redirectUID)
+
+ unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerID: user.ID, OwnerName: user.Name})
+ })
+}
+
func TestCreateUser_Issue5882(t *testing.T) {
// Init settings
_ = setting.Admin