Icycoide/RSCC-Forge
1
0
Fork 0
forked from kevadesu/forgejo
Code Pull requests Activity

fix: allow actions artifacts storage migration to complete succesfully (#31251)

Browse source 
Change the copy to use `ActionsArtifact.StoragePath` instead of the
`ArtifactPath`. Skip artifacts that are expired, and don't error if the
file to copy does not exist.

---

When trying to migrate actions artifact storage from local to MinIO, we
encountered errors that prevented the process from completing
successfully:

* The migration tries to copy the files using the per-run
`ArtifactPath`, instead of the unique `StoragePath`.
* Artifacts that have been marked expired and had their files deleted
would throw an error
* Artifacts that are pending, but don't have a file uploaded yet will
throw an error.

This PR addresses these cases, and allow the process to complete
successfully.

(cherry picked from commit 8de8972baf5d82ff7b58ed77d78e8e1869e64eb5)
(cherry picked from commit 4afbfd3946)
This commit is contained in:
Rowan Bohde 2024-06-04 23:00:56 -05:00 • committed by GitHub
parent 874dde0d4c
commit ab66bfff91
2 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
release-notes/8.0.0/fix/4085.md Normal file
View file

@ -0,0 +1 @@
- `forgejo migrate-storage --type actions-artifacts` always fails because it picks the wrong path