feat(tmpl): Introduce semantic HTML in forms

Modifies forms:

- (new) org team
- (new) repo webhook
- (new) repo protected branch

The forms are not completely rewritten to semantic HTML yet. The focus
of this change was on standard elements, some custom solutions were left
untouched for now.

- swaps the order fo permission radio buttons as per https://codeberg.org/forgejo/forgejo/issues/4983
- uses fieldsets to group related inputs
  - ensures consistent styling across forms
  - can be improved later, e.g. using horizontal lines between sections
- fixes: previous font size of labels was smaller than the font size of the help text
- help text are now part of the label, clicking them now also activates the input
- drop unused CSS (no required checkboxes in grouped class remain)
- playwright testing:
  - move login boilerplate to utils
  - automated form accessibility checking
    - allow defining the scope, because legacy parts of the forms are not yet accessible
  - assert some CSS properties that should not be overriden
- the Makefile adjustment was necessary, because eslint scanned some internal files in the tests/e2e/reports directory

tests/e2e/issue-sidebar.test.e2e.js

@@ -1,16 +1,11 @@
 // @ts-check
 import {expect} from '@playwright/test';
-import {test, login_user, load_logged_in_context} from './utils_e2e.js';
+import {test, login_user, login} from './utils_e2e.js';
 
 test.beforeAll(async ({browser}, workerInfo) => {
   await login_user(browser, workerInfo, 'user2');
 });
 
-async function login({browser}, workerInfo) {
-  const context = await load_logged_in_context(browser, workerInfo, 'user2');
-  return await context.newPage();
-}
-
 // belongs to test: Pull: Toggle WIP
 const prTitle = 'pull5';
 

tests/e2e/org-settings.test.e2e.js

@@ -0,0 +1,25 @@
+// @ts-check
+import {expect} from '@playwright/test';
+import {test, login_user, login} from './utils_e2e.js';
+import {validate_form} from './shared/forms.js';
+
+test.beforeAll(async ({browser}, workerInfo) => {
+  await login_user(browser, workerInfo, 'user2');
+});
+
+test('org team settings', async ({browser}, workerInfo) => {
+  test.skip(workerInfo.project.name === 'Mobile Safari', 'Cannot get it to work - as usual');
+  const page = await login({browser}, workerInfo);
+  const response = await page.goto('/org/org3/teams/team1/edit');
+  await expect(response?.status()).toBe(200);
+
+  await page.locator('input[name="permission"][value="admin"]').click();
+  await expect(page.locator('.team-units')).toBeHidden();
+
+  // we are validating the form here, because the now hidden part has accessibility issues anyway
+  // this should be moved up or down once they are fixed.
+  await validate_form({page});
+
+  await page.locator('input[name="permission"][value="read"]').click();
+  await expect(page.locator('.team-units')).toBeVisible();
+});

tests/e2e/repo-settings.test.e2e.js

@@ -0,0 +1,37 @@
+// @ts-check
+import {expect} from '@playwright/test';
+import {test, login_user, login} from './utils_e2e.js';
+import {validate_form} from './shared/forms.js';
+
+test.beforeAll(async ({browser}, workerInfo) => {
+  await login_user(browser, workerInfo, 'user2');
+});
+
+test('repo webhook settings', async ({browser}, workerInfo) => {
+  test.skip(workerInfo.project.name === 'Mobile Safari', 'Cannot get it to work - as usual');
+  const page = await login({browser}, workerInfo);
+  const response = await page.goto('/user2/repo1/settings/hooks/forgejo/new');
+  await expect(response?.status()).toBe(200);
+
+  await page.locator('input[name="events"][value="choose_events"]').click();
+  await expect(page.locator('.events.fields')).toBeVisible();
+
+  await page.locator('input[name="events"][value="push_only"]').click();
+  await expect(page.locator('.events.fields')).toBeHidden();
+  await page.locator('input[name="events"][value="send_everything"]').click();
+  await expect(page.locator('.events.fields')).toBeHidden();
+
+  // restrict to improved semantic HTML, the rest of the page fails the accessibility check
+  // only execute when the ugly part is hidden - would benefit from refactoring, too
+  await validate_form({page}, 'fieldset');
+});
+
+test('repo branch protection settings', async ({browser}, workerInfo) => {
+  test.skip(workerInfo.project.name === 'Mobile Safari', 'Cannot get it to work - as usual');
+  const page = await login({browser}, workerInfo);
+  const response = await page.goto('/user2/repo1/settings/branches/edit');
+  await expect(response?.status()).toBe(200);
+
+  // not yet accessible :(
+  // await validate_form({page}, 'fieldset');
+});

tests/e2e/shared/forms.js

@@ -0,0 +1,16 @@
+import {expect} from '@playwright/test';
+import AxeBuilder from '@axe-core/playwright';
+
+export async function validate_form({page}, scope) {
+  scope ??= 'form';
+  const accessibilityScanResults = await new AxeBuilder({page}).include(scope).analyze();
+  expect(accessibilityScanResults.violations).toEqual([]);
+
+  // assert CSS properties that needed to be overriden for forms (ensure they remain active)
+  const boxes = page.getByRole('checkbox').or(page.getByRole('radio'));
+  for (const b of await boxes.all()) {
+    await expect(b).toHaveCSS('margin-left', '0px');
+    await expect(b).toHaveCSS('margin-top', '0px');
+    await expect(b).toHaveCSS('vertical-align', 'baseline');
+  }
+}

tests/e2e/utils_e2e.js

@@ -58,6 +58,11 @@ export async function load_logged_in_context(browser, workerInfo, user) {
   return context;
 }
 
+export async function login({browser}, workerInfo) {
+  const context = await load_logged_in_context(browser, workerInfo, 'user2');
+  return await context.newPage();
+}
+
 export async function save_visual(page) {
   // Optionally include visual testing
   if (process.env.VISUAL_TEST) {