Merge pull request #2160 from dalf/test_load_engine

[enh] test: load each engine to check for syntax errors
This commit is contained in:
Adam Tauber 2020-08-31 14:29:52 +02:00 committed by GitHub
commit 6f9aa0e258
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 12 deletions

View file

@ -72,11 +72,8 @@ def load_engine(engine_data):
engine_module = engine_data['engine']
try:
engine = load_module(engine_module + '.py', engine_dir)
except:
logger.exception('Cannot load engine "{}"'.format(engine_module))
return None
# can raise an exception
engine = load_module(engine_module + '.py', engine_dir)
for param_name in engine_data:
if param_name == 'engine':
@ -254,9 +251,11 @@ def load_engines(engine_list):
global engines
engines.clear()
for engine_data in engine_list:
engine = load_engine(engine_data)
if engine is not None:
try:
engine = load_engine(engine_data)
engines[engine.name] = engine
except:
logger.exception('Cannot load engine "{}"'.format(engine_data['engine']))
return engines