From 0aab2d38a7d91bc8caff332e452364468ce52d9a Mon Sep 17 00:00:00 2001
From: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
Date: Tue, 5 Dec 2023 15:30:43 +0800
Subject: [PATCH] Remove deprecated query condition in ListReleases (#28339)
close #24057
call stack:
https://github.com/go-gitea/gitea/blob/25faee3c5f5be23c99b3b7e50418fc0dbad7a41b/routers/api/v1/repo/release.go#L154
https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/routers/api/v1/utils/page.go#L13-L18
https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/convert/utils.go#L15-L22
## :warning: Breaking :warning: (though it's not caused by this PR)
Do not use `per_page` to specify pagination; use `limit` instead
---
routers/api/v1/repo/release.go | 8 --------
templates/swagger/v1_json.tmpl | 6 ------
2 files changed, 14 deletions(-)
diff --git a/routers/api/v1/repo/release.go b/routers/api/v1/repo/release.go
index 6c70bffca3..b1d3b5f457 100644
--- a/routers/api/v1/repo/release.go
+++ b/routers/api/v1/repo/release.go
@@ -133,11 +133,6 @@ func ListReleases(ctx *context.APIContext) {
// in: query
// description: filter (exclude / include) pre-releases
// type: boolean
- // - name: per_page
- // in: query
- // description: page size of results, deprecated - use limit
- // type: integer
- // deprecated: true
// - name: page
// in: query
// description: page number of results to return (1-based)
@@ -152,9 +147,6 @@ func ListReleases(ctx *context.APIContext) {
// "404":
// "$ref": "#/responses/notFound"
listOptions := utils.GetListOptions(ctx)
- if listOptions.PageSize == 0 && ctx.FormInt("per_page") != 0 {
- listOptions.PageSize = ctx.FormInt("per_page")
- }
opts := repo_model.FindReleasesOptions{
ListOptions: listOptions,
diff --git a/templates/swagger/v1_json.tmpl b/templates/swagger/v1_json.tmpl
index d32684c1af..2541726a64 100644
--- a/templates/swagger/v1_json.tmpl
+++ b/templates/swagger/v1_json.tmpl
@@ -11728,12 +11728,6 @@
"name": "pre-release",
"in": "query"
},
- {
- "type": "integer",
- "description": "page size of results, deprecated - use limit",
- "name": "per_page",
- "in": "query"
- },
{
"type": "integer",
"description": "page number of results to return (1-based)",