From 552cfe75f5c999bb0e8650e2a3b89e4c2374f6e3 Mon Sep 17 00:00:00 2001 From: Gusted Date: Fri, 31 Jan 2025 11:12:31 +0100 Subject: [PATCH] chore: Remove `TemporaryUploadRepository.GetLastCommit` - Introduced in 2262811e407facea09047e94aa1850c192511587 and removed in the same commit. Never used. --- .deadcode-out | 2 -- services/repository/files/temp_repo.go | 18 ------------------ 2 files changed, 20 deletions(-) diff --git a/.deadcode-out b/.deadcode-out index 976e0b28e5..6c59cb031b 100644 --- a/.deadcode-out +++ b/.deadcode-out @@ -265,8 +265,6 @@ code.gitea.io/gitea/services/repository code.gitea.io/gitea/services/repository/files ContentType.String GetFileResponseFromCommit - TemporaryUploadRepository.GetLastCommit - TemporaryUploadRepository.GetLastCommitByRef code.gitea.io/gitea/services/webhook NewNotifier diff --git a/services/repository/files/temp_repo.go b/services/repository/files/temp_repo.go index 6e7570b82c..30d95ba9ab 100644 --- a/services/repository/files/temp_repo.go +++ b/services/repository/files/temp_repo.go @@ -212,24 +212,6 @@ func (t *TemporaryUploadRepository) WriteTree() (string, error) { return strings.TrimSpace(stdout), nil } -// GetLastCommit gets the last commit ID SHA of the repo -func (t *TemporaryUploadRepository) GetLastCommit() (string, error) { - return t.GetLastCommitByRef("HEAD") -} - -// GetLastCommitByRef gets the last commit ID SHA of the repo by ref -func (t *TemporaryUploadRepository) GetLastCommitByRef(ref string) (string, error) { - if ref == "" { - ref = "HEAD" - } - stdout, _, err := git.NewCommand(t.ctx, "rev-parse").AddDynamicArguments(ref).RunStdString(&git.RunOpts{Dir: t.basePath}) - if err != nil { - log.Error("Unable to get last ref for %s in temporary repo: %s(%s): Error: %v", ref, t.repo.FullName(), t.basePath, err) - return "", fmt.Errorf("Unable to rev-parse %s in temporary repo for: %s Error: %w", ref, t.repo.FullName(), err) - } - return strings.TrimSpace(stdout), nil -} - // CommitTree creates a commit from a given tree for the user with provided message func (t *TemporaryUploadRepository) CommitTree(parent string, author, committer *user_model.User, treeHash, message string, signoff bool) (string, error) { return t.CommitTreeWithDate(parent, author, committer, treeHash, message, signoff, time.Now(), time.Now())