mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-10 05:06:44 +02:00
feat(ui): add links to review request targets in issue comments (#8239)
- Add links to review request targets in issue comments - Fix links to ghost users/orgs/teams to be empty Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8239 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Robert Wolff <mahlzahn@posteo.de> Co-committed-by: Robert Wolff <mahlzahn@posteo.de>
This commit is contained in:
parent
82daae4c7c
commit
7643bdd2b5
11 changed files with 256 additions and 21 deletions
|
@ -10,6 +10,7 @@ import (
|
|||
|
||||
"forgejo.org/models/db"
|
||||
issues_model "forgejo.org/models/issues"
|
||||
org_model "forgejo.org/models/organization"
|
||||
"forgejo.org/models/unittest"
|
||||
user_model "forgejo.org/models/user"
|
||||
"forgejo.org/modules/setting"
|
||||
|
@ -266,3 +267,19 @@ func TestRenderUser(t *testing.T) {
|
|||
assert.Contains(t, RenderUser(db.DefaultContext, *ghost),
|
||||
"<strong>Ghost</strong>")
|
||||
}
|
||||
|
||||
func TestRenderReviewRequest(t *testing.T) {
|
||||
unittest.PrepareTestEnv(t)
|
||||
|
||||
target1 := issues_model.RequestReviewTarget{User: &user_model.User{ID: 1, Name: "user1", FullName: "User <One>"}}
|
||||
target2 := issues_model.RequestReviewTarget{Team: &org_model.Team{ID: 2, Name: "Team2", OrgID: 3}}
|
||||
target3 := issues_model.RequestReviewTarget{Team: org_model.NewGhostTeam()}
|
||||
assert.Contains(t, RenderReviewRequest(db.DefaultContext, []issues_model.RequestReviewTarget{target1, target2, target3}),
|
||||
"<a href='/user1' rel='nofollow'><strong>user1</strong></a>, "+
|
||||
"<a href='/org/org3/teams/Team2' rel='nofollow'><strong>Team2</strong></a>, "+
|
||||
"<strong>Ghost team</strong>")
|
||||
|
||||
defer test.MockVariableValue(&setting.UI.DefaultShowFullName, true)()
|
||||
assert.Contains(t, RenderReviewRequest(db.DefaultContext, []issues_model.RequestReviewTarget{target1}),
|
||||
"<a href='/user1' rel='nofollow'><strong>User <One></strong></a>")
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue