mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-12 14:16:57 +02:00
feat: remove fomantic's tab module (#8587)
In similar vein of forgejo/forgejo#7416 - Fomantic's tab module is responsible for showing the right content when a tab is clicked upon. Most notably the Write/Preview tabs on the comment editor. - Remove it and replace the javascript with our own function that is able to provide everything Forgejo needs. - Replace the CSS with our own bare minimum CSS. - No functionality or visual is affected by this replacement. - E2E test added. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8587 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
This commit is contained in:
parent
199d9cf65c
commit
8e4f50a909
12 changed files with 123 additions and 1093 deletions
|
@ -10,6 +10,7 @@ import {easyMDEToolbarActions} from './EasyMDEToolbarActions.js';
|
|||
import {initTextExpander} from './TextExpander.js';
|
||||
import {showErrorToast, showHintToast} from '../../modules/toast.js';
|
||||
import {POST} from '../../modules/fetch.js';
|
||||
import {initTab} from '../../modules/tab.ts';
|
||||
|
||||
/**
|
||||
* validate if the given textarea is non-empty.
|
||||
|
@ -200,7 +201,8 @@ class ComboMarkdownEditor {
|
|||
|
||||
setupTab() {
|
||||
const $container = $(this.container);
|
||||
const tabs = $container[0].querySelectorAll('.switch > .item');
|
||||
const switchEl = $container[0].querySelector('.switch');
|
||||
const tabs = switchEl.querySelectorAll('.item');
|
||||
|
||||
// Fomantic Tab requires the "data-tab" to be globally unique.
|
||||
// So here it uses our defined "data-tab-for" and "data-tab-panel" to generate the "data-tab" attribute for Fomantic.
|
||||
|
@ -221,7 +223,7 @@ class ComboMarkdownEditor {
|
|||
});
|
||||
});
|
||||
|
||||
$(tabs).tab();
|
||||
initTab(switchEl);
|
||||
|
||||
this.previewUrl = tabPreviewer.getAttribute('data-preview-url');
|
||||
this.previewContext = tabPreviewer.getAttribute('data-preview-context');
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue