mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-11 13:46:45 +02:00
13e48ead92
- Use the keying module, that was introduced in forgejo/forgejo#5041, to store action secrets safely and securely in the database. - Introduce a central function that sets the secret, `SetSecret` and let the caller do the update call. This is similar to how the twofactor (TOTP) models does it. Ref. https://codeberg.org/forgejo/forgejo/pulls/6074 - Add a relaxed migration, that is run inside a transaction. If it cannot decrypt a action secret, then it's deleted. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8692 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
83 lines
1.8 KiB
Go
83 lines
1.8 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package secrets
|
|
|
|
import (
|
|
"context"
|
|
|
|
"forgejo.org/models/db"
|
|
secret_model "forgejo.org/models/secret"
|
|
)
|
|
|
|
func CreateOrUpdateSecret(ctx context.Context, ownerID, repoID int64, name, data string) (*secret_model.Secret, bool, error) {
|
|
if err := ValidateName(name); err != nil {
|
|
return nil, false, err
|
|
}
|
|
|
|
s, exists, err := db.Get[secret_model.Secret](ctx, secret_model.FindSecretsOptions{
|
|
OwnerID: ownerID,
|
|
RepoID: repoID,
|
|
Name: name,
|
|
}.ToConds())
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
|
|
if !exists {
|
|
s, err := secret_model.InsertEncryptedSecret(ctx, ownerID, repoID, name, data)
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
return s, true, nil
|
|
}
|
|
|
|
s.SetSecret(data)
|
|
if _, err := db.GetEngine(ctx).Cols("data").ID(s.ID).Update(s); err != nil {
|
|
return nil, false, err
|
|
}
|
|
return s, false, nil
|
|
}
|
|
|
|
func DeleteSecretByID(ctx context.Context, ownerID, repoID, secretID int64) error {
|
|
s, err := db.Find[secret_model.Secret](ctx, secret_model.FindSecretsOptions{
|
|
OwnerID: ownerID,
|
|
RepoID: repoID,
|
|
SecretID: secretID,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(s) != 1 {
|
|
return secret_model.ErrSecretNotFound{}
|
|
}
|
|
|
|
return deleteSecret(ctx, s[0])
|
|
}
|
|
|
|
func DeleteSecretByName(ctx context.Context, ownerID, repoID int64, name string) error {
|
|
if err := ValidateName(name); err != nil {
|
|
return err
|
|
}
|
|
|
|
s, err := db.Find[secret_model.Secret](ctx, secret_model.FindSecretsOptions{
|
|
OwnerID: ownerID,
|
|
RepoID: repoID,
|
|
Name: name,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(s) != 1 {
|
|
return secret_model.ErrSecretNotFound{}
|
|
}
|
|
|
|
return deleteSecret(ctx, s[0])
|
|
}
|
|
|
|
func deleteSecret(ctx context.Context, s *secret_model.Secret) error {
|
|
if _, err := db.DeleteByID[secret_model.Secret](ctx, s.ID); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|