mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-14 07:06:49 +02:00
83ea43cf49
After seeing #8111 use a webcomponent, I think that they are a neat usecase for Forgejo where most of the frontend is backend-generated, with some "island of enhancements". I am considering using a webcomponent for the CITATION management (last occurrence of [`Blob.GetBlobContent`](https://codeberg.org/forgejo/forgejo/issues/8222)), however I noticed that the developer experience wasn't ideal. With this PR it would be very easy to declare a webcomponent, which will be loaded only if needed (I converted `model-viewer` and `pdf-object` to this technique). Some cleanup in the neighbor webcomponents. ## Testing 1) Create a new repository or use an existing one. 2) Upload a `.pdf` or `.glb` file (such as https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/testdata/data/viewer/Unicode%E2%9D%A4%E2%99%BBTest.glb) 3) Open the Network inspector and view the file in the repository. - After a short loading spinner, the PDF or 3D model should be rendered in a viewer - the related JS should have been loaded (e.g. http://localhost:3000/assets/js/model-viewer.494bf0cd.js) - visiting another page and check that this JS file isn't loaded Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8510 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Reviewed-by: Beowulf <beowulf@beocode.eu> Co-authored-by: oliverpool <git@olivier.pfad.fr> Co-committed-by: oliverpool <git@olivier.pfad.fr> |
||
|---|---|---|
| .. | ||
| units | ||
| webhook | ||
| actions.tmpl | ||
| branches.tmpl | ||
| collaboration.tmpl | ||
| deploy_keys.tmpl | ||
| githook_edit.tmpl | ||
| githooks.tmpl | ||
| layout_footer.tmpl | ||
| layout_head.tmpl | ||
| lfs.tmpl | ||
| lfs_file.tmpl | ||
| lfs_file_find.tmpl | ||
| lfs_locks.tmpl | ||
| lfs_pointers.tmpl | ||
| navbar.tmpl | ||
| options.tmpl | ||
| protected_branch.tmpl | ||
| push_mirror_sync_modal.tmpl | ||
| runner_edit.tmpl | ||
| secrets.tmpl | ||
| tags.tmpl | ||
| units.tmpl | ||